Interstitial bareground#1577
Draft
glemieux wants to merge 5 commits into
Draft
Conversation
This reflects that the output will be a fraction dependent on certain logic having to do with handling bareground
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
7 tasks
glemieux
commented
Jun 14, 2026
| bare_frac_area = (1.0_r8 - local_patch_fraction) * & | ||
| (currentPatch%area/AREA) | ||
|
|
||
| total_patch_area = total_patch_area + bc_out(s)%canopy_fraction_pa(ifp) + bare_frac_area |
Contributor
Author
There was a problem hiding this comment.
Note that this is dead code being removed (total_patch_area). It wasn't being used downstream.
glemieux
commented
Jun 26, 2026
Comment on lines
+1449
to
+1451
| bc_out(s)%z0m_pa(ifp) = EDPftvarcon_inst%z0mr(1) * bc_out(s)%htop_pa(ifp) | ||
| bc_out(s)%displa_pa(ifp) = EDPftvarcon_inst%displar(1) * bc_out(s)%htop_pa(ifp) | ||
| bc_out(s)%dleaf_pa(ifp) = EDPftvarcon_inst%dleaf(1) |
Contributor
Author
There was a problem hiding this comment.
Q: Is this still valid regardless of the inclusion of interstitial bareground or not? Or do we need a different calculation if there truly is no canopy? What do HLM's use for pure bareground in this case?
glemieux
commented
Jun 26, 2026
| weight = min(1.0_r8,currentCohort%c_area/currentPatch%total_canopy_area) | ||
| weight = min(1.0_r8,currentCohort%c_area/weighting_area) | ||
| bc_out(s)%z0m_pa(ifp) = bc_out(s)%z0m_pa(ifp) + & | ||
| EDPftvarcon_inst%z0mr(currentCohort%pft) * currentCohort%height * weight |
Contributor
Author
There was a problem hiding this comment.
Q: Does more of this calculation need to change if we are including the interstitial bareground?
glemieux
force-pushed
the
interstitial_bareground_option
branch
from
72d4d2e to
389f7e8
Compare
glemieux
force-pushed
the
interstitial_bareground_option
branch
from
389f7e8 to
f8dc5ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes how FATES handles interstitial bareground
Description:
CLM associated pull request is ESCOMP/CTSM#4094
Collaborators:
@ckoven
Expectation of Answer Changes: Yes
Description of generative AI usage (as necessary)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: